Change button foreground color in Latte for better readability

[PinkSerenity]

This changes the button foreground color (previously #ccd0da) in Latte to the accent color. See #53.

[sgoudham]

Hi, the files you edited are generated via catppuccin/whiskers which is our in-house templating tool.

In order for this PR to be accepted, you will need to download whiskers, edit the react_native.tera template, and run whiskers react_native.tera until the output matches the files changed in this PR.

[Covkie]

Raw strings (which were edited here) don't actually have a _dark_ and _light_ field that semantics do. To not effect the dark flavours we'll have to create a mixin that renders a different colour based on if the tera is generating a light (latte) theme or not

[sgoudham]

You can create a wrapper if you want but it's fairly simple anyways, e.g.

#{{ if(cond=flavor.dark, t=surface1.hex, f=subtext1.hex) }}

[Covkie]

I suggested a wrapper as I assume there's more cases where it should be tweaked

[PinkSerenity]

Hi, the files you edited are generated via catppuccin/whiskers which is our in-house templating tool.

In order for this PR to be accepted, uou will need to download whiskers, edit the react_native.tera template, and run whiskers react_native.tera until the output matches the files changed in this PR.

Huh. I already wondered whether there wasn't an easier way. Alright, I'll try that. Thank you.

[Covkie]

can you also show screenshots of what this changes?

[PinkSerenity]

can you also show screenshots of what this changes?
Sure:

Without the change:

With the change:

I now need to figure out how to reopen this after I undid my commits and instead edited the .tera file.

[Covkie]

you are affecting the dark themes as well. the string on the dark themes is used elsewhere. Also, split the changes and tera generation into separate commits. I also dont like the idea of using accent there. it should be a lighter surface or overlay

I can do so if you're unable.

[PinkSerenity]

you are affecting the dark themes as well. the string on the dark themes is used elsewhere.

I'm sorry, I'm still trying to get the hang of all these variables. Maybe I should first focus on that. What I don't yet understand is why the buttons don't have the color in dark mode but do in light mode? Does Discord asign different variables for surfaces in light mode? Because that makes things really complicated.

[Covkie]

@PinkSerenity yes, different variables are used in different places on light and dark. Thats why semantic has multiple fields. Raw doesnt though so we need to do that processing in the tera.

[Covkie]

Oh, as mentioned in #53 (comment) I dont think I want to approve this until the light loading inconsistentcies are fixed. I've just realized what the issue is.

[PinkSerenity]

~~ Oh, as mentioned in #53 (comment) I dont think I want to approve this until the light loading inconsistentcies are fixed. ~~ I've just realized what the issue is.

Yeah, I agree. I will just leave it open and will likely use the themes from my repository as my daily driver until then.

Edit: And I just saw what you've written in the issue. Seems like it got resolved fairly quickly.