Skip to content

feat: use new ansi colors#7

Draft
uncenter wants to merge 1 commit intomainfrom
feat/ansi
Draft

feat: use new ansi colors#7
uncenter wants to merge 1 commit intomainfrom
feat/ansi

Conversation

@uncenter
Copy link
Copy Markdown
Member

@uncenter uncenter commented Dec 9, 2024

Possibly closes #6. Ref catppuccin/whiskers#66.

@perryhq
Copy link
Copy Markdown

perryhq commented Jan 5, 2025

Why is this a draft? It should be merged even if it doesn't fix the issue.

@uncenter
Copy link
Copy Markdown
Member Author

uncenter commented Jan 5, 2025

Why is this a draft? It should be merged even if it doesn't fix the issue.

ANSI colors aren't even merged as part of Whiskers.

@perryhq
Copy link
Copy Markdown

perryhq commented Jan 5, 2025

Really? I remember seeing a issue in the Windows Terminal repo that's at least 6 months old by now asking for the new ANSI colors.

@uncenter
Copy link
Copy Markdown
Member Author

uncenter commented Jan 5, 2025

That's your issue, and yep ANSI colors were only released at the end of October and haven't made their way into our tooling or ports.

@perryhq
Copy link
Copy Markdown

perryhq commented Jan 5, 2025

I forgot I made the issue because I haven't checked it in so long, I only remembered it exists. So I got really lucky and unlucky at the same time because the last time I checked the progress on ANSI colors they were already in the style guide and I knew the branches mentioned in the repos existed so I assumed whiskers already had full ANSI support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GRC colorization

2 participants