Add/fix missing/incorrect field definitions for records #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callum027
force-pushed
the
callum/field-fixes
branch
from
53ae17d to
ba2bdb8
Compare
Callum027
force-pushed
the
callum/field-fixes
branch
2 times, most recently
from
fb757b2 to
156a8e8
Compare
* Add the missing `active` field to the `Product` record class. * Add the missing `sale_ok` field to the `Product` record class. * Fix the incorrect `default_code` field definition on the `Product` record class, by making it optional. * Add the missing `invoice_count` field to the `SaleOrder` record class. * Add the missing `invoice_ids` and `invoices` fields to the `SaleOrder` record class. * Add the missing `action_cancel` method to the `SaleOrder` record and manager class. * Fix a bug where new-style union type hints were not being handled by the parser, due to `typing.get_origin` returning a different origin type from the older `typing.Union` construct.
Callum027
force-pushed
the
callum/field-fixes
branch
from
156a8e8 to
796b544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
activefield to theProductrecord class.sale_okfield to theProductrecord class.default_codefield definition on theProductrecord class, by making it optional.invoice_countfield to theSaleOrderrecord class.invoice_idsandinvoicesfields to theSaleOrderrecord class.action_cancelmethod to theSaleOrderrecord and manager class.typing.get_originreturning a different origin type from the oldertyping.Unionconstruct.