Remove SimpleAST's false Reference subtypes, and add a missing one
#710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
force-pushed
the
refactor/simple-ast-reference-subclasses
branch
from
18e89f6 to
f2bc4a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #708 and #709.
This PR reduces the set of
Referencesubclasses to only five. Four of them correspond to the principal types of "locations" (as per ECMA-335):ArgumentReference)LocalReference)FieldReference)ArrayElementReference)A fifth one,
IndirectReference(essentially this is the pointer indirection / dereference operator), is preserved because it is convenient for code generation involving by-refs.