Refactor SimpleAST for clear distinction between expressions and locations
#707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'm not really happy yet with this PR. I'll probably split it up into a few smaller ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for #663, where it will be necessary to adjust many code locations dealing with conversion of arguments that get passed around both by-value and by-reference. I find DynamicProxy's handling of by-ref arguments especially hard to understand, and that is in part due to the structuring of the CIL syntax trees.
This PR does lots of little things, but the main goal is introducing a clear distinction in the
SimpleASTsyntax nodes between expressions/statements and references. The latter are being renamed "locations" to better match ECMA-335 terminology (see section I.8.3).Way too many of the
Referencenode types aren't really locations at all, and are thus "down-gradeed" to expressions.There's also some code duplication being removed here. Nodes that do too many different things are being replaced with simpler single-purpose nodes that compose better than the previous node types.