Skip to content

Conversation

@Romfos
Copy link
Contributor

@Romfos Romfos commented Nov 29, 2025

Changes:

How to use:
image

If you want to publish directly to nuget owner of this repo should set NUGET_API_KEY to the repo secrets and check "publish to nuget" during release build

@Romfos Romfos marked this pull request as ready for review November 29, 2025 20:55
@Romfos
Copy link
Contributor Author

Romfos commented Nov 29, 2025

Maybe someone know - what is "Castle.Core.Tests.WeakNamed"? What is the purpose of that?

cc @stakx

@Romfos Romfos mentioned this pull request Nov 29, 2025
10 tasks
@stakx
Copy link
Member

stakx commented Nov 29, 2025

Sorry, I currently don't have sufficient capacity to look into migrating away from Appveyor if I also want to look at actually improving DynamicProxy. I'd rather spend some of my time there at the moment.

Getting rid of Appveyor will be a good thing... but hopefully it can wait a little longer.

Leaving this PR open to be reviewed at a later time (or by someone else).

Maybe someone know - what is "Castle.Core.Tests.WeakNamed"? What is the purpose of that?

DynamicProxy has to be able to deal with types both from strong-named ("signed") and non-strong-named ("unsigned") assemblies. Depending on whether a type to be proxied comes from one or the other, DynamicProxy needs to do slightly different things. Therefore we need both strong-named and non-strong-named assemblies in our test suite to cover all those cases. The Castle.Core.Tests.WeakNamed project targets the latter.

@Romfos
Copy link
Contributor Author

Romfos commented Nov 29, 2025

sad. As I See appveyor image doesn't have .NET 10 for now., This is blocked for this

@stakx
Copy link
Member

stakx commented Dec 9, 2025

appveyor image doesn't have .NET 10 for now., This is blocked for this

@Romfos, note that the .NET 10 SDK can be installed before the AppVeyor CI run commences: 4f624b0. (Relevant AppVeyor documentation for that is here.) The tradeoff being that the AppVeyor builds become even slower.

(To be honest, I'm getting around to your point of view: it'll be good to be rid of it ASAP. That being said, see my comment in #699 (comment). Let's probably do this for the next release after 6.0.0.)

@stakx stakx changed the title Drop appveyor in favor of github actions Drop AppVeyor in favor of GitHub Actions Dec 10, 2025
@Romfos
Copy link
Contributor Author

Romfos commented Dec 11, 2025

ok, rebased

cc @jonorossi

@stakx
Copy link
Member

stakx commented Dec 12, 2025

FYI, I've also contacted jonorossi regarding the NuGet API key in GitHub Actions config. Let's proceed once that is set up.

@stakx stakx marked this pull request as draft December 17, 2025 18:04
@stakx
Copy link
Member

stakx commented Dec 17, 2025

@Romfos, I'm marking this PR as a "draft" to prevent accidental merging. I want to make sure the NuGet publishing is fully set up before this lands on master. But I'm still on board with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants