Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
==========================================
+ Coverage 61.51% 67.76% +6.25%
==========================================
Files 93 93
Lines 11051 11051
==========================================
+ Hits 6798 7489 +691
+ Misses 4253 3562 -691 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Switch prepare to setup-python v6 with explicit Poetry installation, and refactor checks to reuse the prepare action while aligning defaults to Python 3.10 and Poetry 2.3.2.
- bump workflow actions to current majors - standardize python defaults to 3.10 in reusable workflows - standardize poetry defaults to 2.3.2 across CI jobs Signed-off-by: b-l-u-e <winnie.gitau282@gmail.com>
- normalize python examples to 3.10 - update poetry install version to 2.3.2 - keep Dockerfile poetry version in sync with CI/docs Signed-off-by: b-l-u-e <winnie.gitau282@gmail.com>
- regenerate lock metadata and normalized markers - keep dependency graph aligned with current poetry toolchain Signed-off-by: b-l-u-e <winnie.gitau282@gmail.com>
- pre-commit-hooks: v4.5.0 -> v6.0.0 - ruff-pre-commit: v0.7.1 -> v0.15.4 - mirrors-mypy: v1.6.0 -> v1.19.1 Signed-off-by: b-l-u-e <winnie.gitau282@gmail.com>
b-l-u-e
force-pushed
the
chore/ci-modernize-workflows
branch
from
d494d6e to
1418cae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to run Nutshell on a fresh setup and noticed several issues:
::set-outputusage producing warningschartboost/ruff-action(replaced byastral-sh/ruff-action)I addressed these by upgrading workflows, aligning docs with the current setup, and bumping pre-commit hooks.
Changes
Workflow infrastructure
actions-poetryv3,setup-pythonv5)chartboost/ruff-actionwithastral-sh/ruff-actionWorkflow updates
::set-outputwith$GITHUB_OUTPUTin docker.yamlactions/checkoutto v4 andcodecov-actionto v5poetry-versiondefaults in regtest workflowsDocumentation
cashu-regtest-enviroment)LndRPCWalletto the backend listTooling
Tested
make ruff-check && make mypy && make test