Remove deprecated promises field from PostRestoreResponse#900
Open
coldbrewnosugar wants to merge 1 commit intocashubtc:mainfrom
Open
Remove deprecated promises field from PostRestoreResponse#900coldbrewnosugar wants to merge 1 commit intocashubtc:mainfrom
coldbrewnosugar wants to merge 1 commit intocashubtc:mainfrom
Conversation
The promises field was deprecated in v0.15.1 for backwards compatibility with old cashu-ts clients. cashu-ts removed support for this field in v2.3.0 over a year ago. This removes the field and the associated compatibility shim in the wallet API. Closes cashubtc#898
| ) | ||
| data = response.json() | ||
| assert "promises" in data | ||
| assert "signatures" in data |
Contributor
There was a problem hiding this comment.
This test_api_restore test should just be removed completely from here. The PostRestoreRequest is already tested in the test_mint_api.py with the signatures field. This test was to ensure the backwards compatibility was still valid in its deprecated state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
promisesfield fromPostRestoreResponseand its__init__override that duplicatedsignaturesintopromisespromisesback intosignaturessignaturesinstead ofpromisesThe
promisesfield was deprecated in v0.15.1 for compatibility with old cashu-ts clients. cashu-ts completed the same rename in v2.3.0 (PR #234) over a year ago. CDK is also cleaning this up in #1644.Closes #898