fix: preserve keyset timestamps during rotation (closes #882)#892
Open
joelklabo wants to merge 1 commit intocashubtc:mainfrom
Open
fix: preserve keyset timestamps during rotation (closes #882)#892joelklabo wants to merge 1 commit intocashubtc:mainfrom
joelklabo wants to merge 1 commit intocashubtc:mainfrom
Conversation
- Fix update_keyset to properly preserve existing timestamp values instead of using 'or' which incorrectly treated None values - Set valid_to timestamp when deactivating old keyset during rotation - Fix pre-existing bug: use selected_keyset.id instead of undefined 'keyset' in log message This fixes the bug reported in issue cashubtc#882 where timestamps were being nullified upon keyset rotation.
Collaborator
|
hi, please undo unrelated changes and fix the pipeline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug reported in issue #882 where keyset timestamps (valid_from, valid_to, first_seen) were being nullified upon keyset rotation.
Changes
This addresses the Nodesignal bug bounty.