fix: set/unset melt quote and associated proofs in same transaction#880
Open
a1denvalu3 wants to merge 14 commits intomainfrom
Open
fix: set/unset melt quote and associated proofs in same transaction#880a1denvalu3 wants to merge 14 commits intomainfrom
a1denvalu3 wants to merge 14 commits intomainfrom
Conversation
Contributor
|
This looks good. We should just take this and then add the branch on top. I'll close my draft which got to the same spot but your test looks cleaner and more direct. Approved |
a1denvalu3
force-pushed
the
test/repro-melt-race-condition
branch
from
038f845 to
9556e46
Compare
a1denvalu3
changed the title
a1denvalu3
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
==========================================
- Coverage 64.71% 60.66% -4.05%
==========================================
Files 91 90 -1
Lines 10900 10866 -34
==========================================
- Hits 7054 6592 -462
- Misses 3846 4274 +428 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
LGTM |
KvngMikey
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test case that reproduces a race condition in the melt operation. When two concurrent melt requests attempt to spend the same proofs, one fails as expected, but leaves the proofs in a PENDING state indefinitely.