NUT-21 and NUT-22 matching rules#334
Merged
thesimplekid merged 4 commits intocashubtc:mainfrom Feb 10, 2026
Merged
Conversation
Collaborator
thesimplekid
left a comment
thesimplekid
left a comment
There was a problem hiding this comment.
Looks good. Do you think some test cases would be helpful?
2 tasks
Co-authored-by: tsk <tsk@thesimplekid.com>
Co-authored-by: tsk <tsk@thesimplekid.com>
Contributor
Author
Thanks for removing the prefix anchor - I overlooked that. Am happy to add tests, but wasn't sure a prefix match needs much more explanation than the example given? But am too close to it, so if you think it's open to interpretation, then I will. EDIT: 21a0bd3 adds a couple more examples |
thesimplekid
approved these changes
Jan 30, 2026
Collaborator
thesimplekid
left a comment
thesimplekid
left a comment
There was a problem hiding this comment.
LGTM. CDK PR cashubtc/cdk#1586
5 tasks
Contributor
Author
|
Cashu-TS PR: #334 |
This was referenced Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies
protected_endpointsmatching rules for NUT-21 and NUT-22