Skip to content

feat: add amount to nut05#173

Merged
thesimplekid merged 1 commit intocashubtc:mainfrom
thesimplekid:melt_amountless
Apr 9, 2025
Merged

feat: add amount to nut05#173
thesimplekid merged 1 commit intocashubtc:mainfrom
thesimplekid:melt_amountless

Conversation

@thesimplekid
Copy link
Copy Markdown
Collaborator

@thesimplekid thesimplekid commented Oct 9, 2024

In order to support paying an amount-less invoice, add amount to quote request.

closes #172

@prusnak
Copy link
Copy Markdown
Collaborator

prusnak commented Oct 9, 2024

I think we should specify whether amount can be provided if bolt11 invoice contains an amount.

There are 3 options:
a) amount must not be provided
b) amount can be provided but is ignored
c) amount can be provided but must match the amount in bolt11 invoice

I like the C option the most.

Comment thread 05.md Outdated
@thesimplekid
Copy link
Copy Markdown
Collaborator Author

I think we should specify whether amount can be provided if bolt11 invoice contains an amount.

Good point, I've updated wording to reflect this.

@callebtc
Copy link
Copy Markdown
Contributor

Setting for the info endpoint (some backends can't pay amountless invoices)

@thesimplekid
Copy link
Copy Markdown
Collaborator Author

Setting for the info endpoint (some backends can't pay amountless invoices)

Added in 6628ff1

Comment thread 05.md Outdated
Copy link
Copy Markdown
Collaborator

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK after the new changes

Comment thread 05.md Outdated
Comment thread 05.md Outdated
@a1denvalu3
Copy link
Copy Markdown
Contributor

Nutshell: cashubtc/nutshell#712

Comment thread error_codes.md Outdated
@elnosh
Copy link
Copy Markdown
Contributor

elnosh commented Mar 20, 2025

gonuts: elnosh/gonuts#137
just pending resolution on the conflicting error codes with #223

@thesimplekid thesimplekid merged commit 87067f3 into cashubtc:main Apr 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support paying amountless invoices

5 participants