Update code element from extending screen width on extra parameters field#409
Open
Saurinpatel20 wants to merge 2 commits intocashapp:masterfrom
Open
Update code element from extending screen width on extra parameters field#409Saurinpatel20 wants to merge 2 commits intocashapp:masterfrom
code element from extending screen width on extra parameters field#409Saurinpatel20 wants to merge 2 commits intocashapp:masterfrom
Conversation
Author
|
@mpawliszyn Is it possible to get this merged or get feedback on it? It's a quick styling change... |
Collaborator
|
Right, so note that we will be moving to the new UI soon. Have you run the development app and confirmed this works as you'd expect? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On larger pieces of text, the code element spans the entire width of the screen and extends the text past the width of the page, which makes buttons on the right side of the screen hidden and hard to find without scrolling all the way over.
Updated the styling on this element so that instead of making it overflow and extend the width of the page, we break the word into separate lines. Used
break-allas opposed tobreak-word.