Skip to content

fix fish completions with words containing -f#2861

Closed
azarmadr wants to merge 2 commits intocasey:masterfrom
azarmadr:fish-shell-completion-fix
Closed

fix fish completions with words containing -f#2861
azarmadr wants to merge 2 commits intocasey:masterfrom
azarmadr:fish-shell-completion-fix

Conversation

@azarmadr
Copy link
Copy Markdown
Contributor

@azarmadr azarmadr commented Aug 16, 2025

Fixes #2686

@azarmadr azarmadr force-pushed the fish-shell-completion-fix branch from 99b87a9 to 69c6434 Compare August 17, 2025 04:59
@azarmadr
Copy link
Copy Markdown
Contributor Author

It is a small change. only adding a regex to filter out -f in between words

@azarmadr azarmadr force-pushed the fish-shell-completion-fix branch from 69c6434 to 96cecb5 Compare August 17, 2025 05:12
@casey
Copy link
Copy Markdown
Owner

casey commented Mar 22, 2026

I switched to using Clap's dynamic completion engine in #3167. The new completion engine calls into the just binary to get completions. This allows us to implement custom completion logic in Rust for all supported shells, instead of having to patch in support for each individual shell.

I created #2406 to track improvements to the new completion engine in one place.

I think this should work with the new engine.

@casey casey closed this Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Completions not working in fish shell

2 participants