Skip to content

Conversation

@genedan
Copy link
Collaborator

@genedan genedan commented Jan 22, 2026

Closes #654. Partially addresses #655 regarding the columns_label issue.

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.10%. Comparing base (0341334) to head (08b7a95).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
chainladder/core/pandas.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
+ Coverage   85.05%   85.10%   +0.05%     
==========================================
  Files          85       85              
  Lines        4865     4868       +3     
  Branches      619      619              
==========================================
+ Hits         4138     4143       +5     
+ Misses        518      517       -1     
+ Partials      209      208       -1     
Flag Coverage Δ
unittests 85.10% <88.88%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@henrydingliu henrydingliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a test for the new exception?

@genedan
Copy link
Collaborator Author

genedan commented Jan 22, 2026

k, added a few tests cases (incorrect # columns, misspelled strings, incorrect integer supplied).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add some validation logic to TrianglePandas.rename

2 participants