install script improvements#785
Closed
Jenil1905 wants to merge 1 commit intocarvel-dev:developfrom
Closed
Conversation
✅ Deploy Preview for carvel ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joaopapereira
requested changes
Nov 7, 2024
Member
joaopapereira
left a comment
joaopapereira
left a comment
There was a problem hiding this comment.
The install script is generated from https://github.com/carvel-dev/release-scripts/blob/main/scripts/install_sh/install.sh.txt do you mind moving this PR to that repository?
Author
|
No
…On Fri, 8 Nov 2024 at 4:10 AM, João Pereira ***@***.***> wrote:
***@***.**** requested changes on this pull request.
The install script is generated from
https://github.com/carvel-dev/release-scripts/blob/main/scripts/install_sh/install.sh.txt
do you mind moving this PR to that repository?
—
Reply to this email directly, view it on GitHub
<#785 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKLIOP7TFDDL72NTRNNAB7LZ7PT5PAVCNFSM6AAAAABP5B3WA6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMRSGMYDGNZVGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
Closing this PR in favor of carvel-dev/release-scripts#42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.