fix: pre-clean snapshot dir before store#777
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes snapshot creation resilient to restarts after a partial snapshot write by pre-cleaning the target snapshot directory before invoking the machine snapshot store.
Changes:
- Pre-remove any existing snapshot directory at the intended output path before creating a new snapshot.
- Add a unit test intended to cover retrying snapshot creation when the target directory already exists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/advancer/advancer.go | Pre-cleans the snapshot output path before calling CreateSnapshot to avoid failures on existing directories. |
| internal/advancer/advancer_test.go | Adds a test case for handling a pre-existing (stale) snapshot directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mpolitzer
force-pushed
the
fix/cleanup-on-store
branch
3 times, most recently
from
e4d007b to
79d04d7
Compare
mpolitzer
force-pushed
the
fix/cleanup-on-store
branch
from
79d04d7 to
70d3d0b
Compare
vfusco
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safeguard against a restart after a partial store.