-
Notifications
You must be signed in to change notification settings - Fork 18
chore: update machine emulator submodule #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[eidt: I've already updated the machine/rust-bindings] Hey @GCdePaula . After bumping the emulator, we should re-generate the rust binding, right? |
a740bf8 to
6ca2066
Compare
6ca2066 to
2b96a04
Compare
|
seems like the submodule |
I tried updating the version in Makefile and also fixed a few other problems but I think @cartesi/emulator team knows the best of making proper changes. I couldn't get all tests passing for now. |
|
Thanks Stephen |
|
Hi, are you planning to use the new collect functions? I would like to use them on the Node for the disputes. I would love for the Dave team to have a look into them as well. To make sure they work as expected.
Also, there is a newer version for testing: v0.20.0-test2 that fixes an issue with |
Hey @mpolitzer , thanks for hopping in. We are not trying to use any new features. It's because we can no longer build v19.0.0 with dave CI, so we thought bumping the emulator version might help. There seems to be a missing package but we're not sure how to solve it. |
|
@ZzzzHui Let's pospon this PR for a bit. I've pushed a commit to main that we can still build cartesi machine v0.19.0. Try rebase your work on top of it and see if things work for you. |
|
Ok. Thank you. I will rebase |
bumped emulator submodule to tag v0.20.0-test