Skip to content

fix: linkParams in email template update and upsert #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marinpurgar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: linkParams in email template update and upsert #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36d4d1e
Fix linkParams in email template update and upsert
marinpurgar Nov 3, 2022
e60a459
Fix whitespaces in client.py EOF
marinpurgar Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions iterablepythonwrapper/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,7 +1048,7 @@ def update_email_template(self, template_id, metadata=None,
payload["googleAnalyticsCampaignName"]= google_analytics_campaign_name

if link_parameters is not None:
payload["linkParameters"]= link_parameters
payload["linkParams"]= link_parameters

if data_feed_id is not None:
payload["dataFeedId"]= data_feed_id
Expand Down Expand Up @@ -1126,7 +1126,7 @@ def upsert_email_template(self, client_template_id,
payload["googleAnalyticsCampaignName"]= google_analytics_campaign_name

if link_parameters is not None:
payload["linkParameters"]= link_parameters
payload["linkParams"]= link_parameters

if data_feed_id is not None:
payload["dataFeedId"]= data_feed_id
Expand Down Expand Up @@ -1713,10 +1713,3 @@ def trigger_workflow(self, workflow_id, email=None,
payload["listId"]= list_id

return self.api_call(call=call, method="POST", json=payload)