-
Notifications
You must be signed in to change notification settings - Fork 12
Cs 10383 create listing should have a loading user experience #4190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lucaslyl
wants to merge
23
commits into
main
Choose a base branch
from
CS-10383-create-listing-should-have-a-loading-user-experience
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+899
−73
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8737f7b
remove navigate the listing open in interact mode
lucaslyl d700f68
implement openCreateListingModal as a host command
lucaslyl d793a22
implement command & support create listing from card instances with p…
lucaslyl c62229d
add command test
lucaslyl 5230c83
Merge branch 'main' into CS-10383-create-listing-should-have-a-loadin…
lucaslyl 0d6e5c8
fix lint
lucaslyl 0606903
fix realm index
lucaslyl 5e825a4
address codex feedback
lucaslyl 15cfc04
prevent stale create task from closing newer modal requests
lucaslyl 82239b5
implement oeprator mode toast
lucaslyl 988ef33
Merge branch 'main' into CS-10383-create-listing-should-have-a-loadin…
lucaslyl 0ddd02c
support openCardIDs
lucaslyl 74d2a99
add isListingDef checking
lucaslyl beab058
update test
lucaslyl 13a49f9
remove toast
lucaslyl 0a12266
menu item should pass openCardIds
lucaslyl 368cfd9
fix test
lucaslyl 5336b8c
fix test
lucaslyl 065d64d
remove accidentally added submodule reference
lucaslyl 87624ce
fix lint
lucaslyl 83b9a03
fix test
lucaslyl 5e3dd97
address codex feedback
lucaslyl 7853b39
Merge branch 'main' into CS-10383-create-listing-should-have-a-loadin…
lucaslyl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import { service } from '@ember/service'; | ||
|
|
||
| import type * as BaseCommandModule from 'https://cardstack.com/base/command'; | ||
|
|
||
| import HostBaseCommand from '../lib/host-base-command'; | ||
|
|
||
| import type OperatorModeStateService from '../services/operator-mode-state-service'; | ||
|
|
||
| export default class OpenCreateListingModalCommand extends HostBaseCommand< | ||
| typeof BaseCommandModule.ListingCreateInput | ||
| > { | ||
| @service declare private operatorModeStateService: OperatorModeStateService; | ||
|
|
||
| description = 'Open create listing confirmation modal'; | ||
|
|
||
| async getInputType() { | ||
| let commandModule = await this.loadCommandModule(); | ||
| const { ListingCreateInput } = commandModule; | ||
| return ListingCreateInput; | ||
| } | ||
|
|
||
| requireInputFields = ['codeRef', 'targetRealm']; | ||
|
|
||
| protected async run( | ||
| input: BaseCommandModule.ListingCreateInput, | ||
| ): Promise<undefined> { | ||
| this.operatorModeStateService.showCreateListingModal({ | ||
| codeRef: input.codeRef, | ||
| targetRealm: input.targetRealm, | ||
| openCardIds: input.openCardIds, | ||
| }); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍