fix swapped isIntN arguments in Xtensa decodeOffset_16_16Operand#2988
Closed
Samin061 wants to merge 1 commit into
Closed
fix swapped isIntN arguments in Xtensa decodeOffset_16_16Operand#2988Samin061 wants to merge 1 commit into
Samin061 wants to merge 1 commit into
Conversation
Collaborator
|
This is a clone of #2986 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swapped isIntN arguments in decodeOffset_16_16Operand
isIntN(unsigned N, int64_t x)takes the bit width first, but the check here passes the decoded immediate asN, so it shifts byImm - 1; a smallImmwraps that to a huge unsigned shift count and hits the signed shift/negation UBSan checks inMathExtras.h. Reachable fromcs_disasmon Xtensa input that decodes anOffset_16_16operand (e.g.07 75 5d ce 50 2b 87), and every siblingdecodeOffset_*helper already passes the width first. Added a regression case totest_poc.c.