Fix M68K#2987
Open
b1llow wants to merge 4 commits into
Open
Conversation
Rot127
requested changes
Jul 6, 2026
Rot127
requested changes
Jul 6, 2026
| info->pc = (uint32_t)info->baseAddress; | ||
| } | ||
|
|
||
| #define M68K_GET_EA_OR_INVALID(info, op, instruction, size) \ |
Collaborator
There was a problem hiding this comment.
Sorry, I actually meant: Please don't use a macro but a normal if.
Because without macro we can set breakpoints when debugging. But we can't set breakpoints in macros.
Or is this an issue with my editors I use and it works for you?
Then it doesn't matter and you can keep it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Test plan
...
Closing issues
...