Skip to content

RISCV: compressed insn treats the uncompressed version as an alias #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
slate5 wants to merge 2 commits into
base: next
Choose a base branch
from
+44 −18
Draft

RISCV: compressed insn treats the uncompressed version as an alias #2959

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f839ec
RISCV: compressed insn treats the uncompressed version as an alias
slate5 Jun 9, 2026
66b162f
Swap alias with real operands
slate5 Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 44 additions & 18 deletions arch/RISCV/RISCVInstPrinter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,28 +400,54 @@ void RISCV_LLVM_printInstruction(MCInst *MI, SStream *O,
(is_uncompressed &&
MI->csh->syntax & CS_OPT_SYNTAX_NO_ALIAS_TEXT_COMPRESSED);
if (print_exact_text) {
// while we always print real operands for NO_ALIAS_TEXT, set this explicitly
MI->flat_insn->usesAliasDetails = false;
printInstruction(MI, MI->address, O);
} else {
// side-effectful check for alias instructions that prints to the SStream if true
if (printAliasInstr(McInstr, MI->address, O)) {
MCInst_setIsAlias(MI, true);
// do we still want the exact details even if the text is alias ?
if (!usesAliasDetails && detail_is_set(MI)) {
// disable actual printing
SStream_Close(O);
// discard the alias operands
memset(MI->flat_insn->detail->riscv.operands, 0,
sizeof(MI->flat_insn->detail->riscv
.operands));
MI->flat_insn->detail->riscv.op_count = 0;
// re-disassemble again with no printing in order to obtain the full details
// including the whole operands array
printInstruction(MI, MI->address, O);
// re-open the stream to restore the usual state
SStream_Open(O);
} else if (printAliasInstr(McInstr, MI->address, O)) {
MCInst_setIsAlias(MI, true);
// do we still want the exact details even if the text is alias ?
if (!usesAliasDetails && detail_is_set(MI)) {
// disable actual printing
SStream_Close(O);
// discard the alias operands
memset(MI->flat_insn->detail->riscv.operands, 0,
sizeof(MI->flat_insn->detail->riscv.operands));
MI->flat_insn->detail->riscv.op_count = 0;
// re-disassemble again with no printing in order to obtain the full details
// including the whole operands array
printInstruction(McInstr, MI->address, O);
// re-open the stream to restore the usual state
SStream_Open(O);
}
// the instruction is not an ISA alias, but it still can be an uncompressed "alias"
} else {
if (is_uncompressed) {
unsigned int i =
find_cs_id(MCInst_getOpcode(&Uncompressed),
RISCV_insns, RISCV_insn_count);
if (i != -1) {
Uncompressed.flat_insn->alias_id =
RISCV_insns[i].mapid;
MCInst_setIsAlias(&Uncompressed, true);
}
} else // the instruction is not an alias
}
printInstruction(MI, MI->address, O);

// do we still want the exact details even if the text is alias ?
if (!usesAliasDetails && detail_is_set(MI)) {
// disable actual printing
SStream_Close(O);
// discard the alias operands
memset(MI->flat_insn->detail->riscv.operands, 0,
sizeof(MI->flat_insn->detail->riscv.operands));
MI->flat_insn->detail->riscv.op_count = 0;
// re-disassemble again with no printing in order to obtain the full details
// including the whole operands array
printInstruction(McInstr, MI->address, O);
// re-open the stream to restore the usual state
SStream_Open(O);
}
}
RISCV_add_groups(MI);
RISCV_compact_operands(MI);
Expand Down
Loading