Fix 0-byte file after zip extraction#10
Merged
Merged
Conversation
The archive Dart package loads the entire zip into memory before extracting, causing 0-byte output files for large archives (e.g. 672MB 3DS ROMs). Switch zip extraction to Apache Commons Compress on the Kotlin side, which streams entries to disk with a 64KB buffer — same approach already used for 7z files. Fixes #9
- Route zip extraction through native Apache Commons Compress streaming extractor instead of the archive Dart package which loads entire zip into memory (OOM on large ROMs like 672MB 3DS files) - Fix torrent progress listener calling _finishTorrentTask multiple times by guarding against re-entrant ticks - Show indeterminate progress bar during extraction instead of stuck 0% - Bump version to 1.3.1+4 Fixes #9
caprado
force-pushed
the
fix/zip-extraction-0-byte
branch
from
b8ffbb5 to
dbd56cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
archiveDart packagearchivepackage loads the entire zip into memory before extracting, causing 0-byte output files for large archives (e.g. 672MB 3DS ROMs)Fixes #9
Test plan