Fix memory leak in _DynamicCapabilityClient._send_helper()#398
Open
ed-tsn wants to merge 1 commit intocapnproto:masterfrom
Open
Fix memory leak in _DynamicCapabilityClient._send_helper()#398ed-tsn wants to merge 1 commit intocapnproto:masterfrom
ed-tsn wants to merge 1 commit intocapnproto:masterfrom
Conversation
Author
The heap-allocated Request object was never freed after send(). Each RPC call leaked ~72 bytes, growing linearly with usage. Added del request after request.send() to free the Request once the RemotePromise has been constructed.
ed-tsn
force-pushed
the
fix/send-helper-memory-leak
branch
from
938e33e to
1c7f800
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The heap-allocated Request object was never freed after send().
Each RPC call leaked ~72 bytes, growing linearly with usage.
Added del request after request.send() to free the Request once
the RemotePromise has been constructed.