add options for composer and php binaries #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `:composer_bin` and `:composer_php` options for better control of which binaries to use. When not explicitly set, the existence of the `composer` and `php` executables is now validated before the tasks are run. Also Composer is now always invoked through php. For this the path to the `composer` executable is expanded by calling `which composer` on the remote host. When `:composer_bin` is set to `:local`, `composer:install_executable` is automatically invoked on deployment. So no more manual hooking of additional tasks in the deploy configuration.
Contributor
Author
|
ping ✨ |
|
This PR would be very helpful since I'm using composer installed as a |
|
Up! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
:composer_binand:composer_phpoptions for better control ofwhich binaries to use.
When not explicitly set, the existence of the
composerandphpexecutables is now validated before the tasks are run.
Also Composer is now always invoked through php. For this the path to
the
composerexecutable is expanded by callingwhich composeronthe remote host.
When
:composer_binis set to:local,composer:install_executableis automatically invoked on deployment. So no more manual hooking of
additional tasks in the deploy configuration.
This more or less supersedes #41, but I think this is more flexible.