Skip to content

fix: remove bogus /v1/pdp/evaluate default from PDP config #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beonde merged 2 commits into from
May 12, 2026
Merged

fix: remove bogus /v1/pdp/evaluate default from PDP config #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
143d146
fix: remove bogus /v1/pdp/evaluate default from PDP config
beonde May 12, 2026
de48dcd
fix: default enforcement mode to EM-GUARD when bundle URL is configured
beonde May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions capiscio_mcp/connect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,10 @@ async def connect(
auto_badge: If ``True``, issue an initial badge and start auto-renewal.
renewal_threshold: Renew badge this many seconds before expiry.
on_badge_renew: Optional callback ``(badge: str) -> None`` on renewal.
pdp_endpoint: Override PDP URL for org-policy enforcement. Defaults
to ``{server_url}/v1/pdp/evaluate`` (zero-config). Can also be
overridden via ``CAPISCIO_PDP_ENDPOINT`` env var.
pdp_endpoint: Optional remote PDP URL for org-policy enforcement.
Defaults to empty (local OPA bundle evaluation via Go core).
Use ``CAPISCIO_PDP_ENDPOINT`` env var or this param only when
a remote PDP service is explicitly deployed.
Comment on lines +310 to +312

Returns:
:class:`MCPServerIdentity` with ``.did``, ``.badge``, ``.keys_dir``,
Expand Down Expand Up @@ -360,6 +361,12 @@ async def connect(
if cached_org_id:
os.environ["CAPISCIO_BUNDLE_URL"] = f"{server_url}/v1/bundles/{cached_org_id}"

# Default enforcement mode to EM-GUARD when a bundle URL is configured.
# EM-OBSERVE (the Go core default) is shadow-mode: logs DENY but allows
# through, which silently breaks policy enforcement for callers.
if os.environ.get("CAPISCIO_BUNDLE_URL") and not os.environ.get("CAPISCIO_ENFORCEMENT_MODE"):
os.environ["CAPISCIO_ENFORCEMENT_MODE"] = "EM-GUARD"

did: Optional[str] = None
private_key_pem: Optional[str] = None
pub_pem: Optional[str] = None
Expand Down Expand Up @@ -506,6 +513,8 @@ async def connect(
# the Go core could be started.)
if org_id and org_id != cached_org_id:
os.environ["CAPISCIO_BUNDLE_URL"] = f"{server_url}/v1/bundles/{org_id}"
if not os.environ.get("CAPISCIO_ENFORCEMENT_MODE"):
os.environ["CAPISCIO_ENFORCEMENT_MODE"] = "EM-GUARD"

# Step 5: Issue initial badge and start keeper
badge: Optional[str] = None
Expand Down Expand Up @@ -540,11 +549,13 @@ async def connect(
)

# Step 7: Auto-configure PDP for org-policy enforcement
# Precedence: explicit param > env var > derived from server_url (zero-config).
# Policy evaluation is LOCAL: the Go core fetches the OPA bundle via
# CAPISCIO_BUNDLE_URL and evaluates it with its embedded OPA engine.
# pdp_endpoint is only needed if a remote PDP is explicitly configured.
effective_pdp = (
pdp_endpoint
or os.environ.get("CAPISCIO_PDP_ENDPOINT")
or f"{server_url}/v1/pdp/evaluate"
or ""
)
set_pip_config(
PIPConfig(
Expand All @@ -553,7 +564,10 @@ async def connect(
workspace=server_id,
)
)
logger.info("Org-policy enforcement enabled: pdp_endpoint=%s", effective_pdp)
if effective_pdp:
logger.info("Remote PDP configured: pdp_endpoint=%s", effective_pdp)
else:
logger.debug("Using local OPA bundle for policy evaluation")
Comment on lines 551 to +570

return cls(
server_id=server_id,
Expand Down
Loading