-
Notifications
You must be signed in to change notification settings - Fork 2
[security] MCP hardening: remove private key logging, wire require_badge #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -285,6 +285,7 @@ async def evaluate_tool_access( | |
| min_trust_level=effective_config.min_trust_level, | ||
| accept_level_zero=effective_config.accept_level_zero, | ||
| allowed_tools=effective_config.allowed_tools or [], | ||
| # TODO: wire require_badge once the proto field is added in capiscio-core | ||
| ), | ||
|
Comment on lines
285
to
289
|
||
| ) | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behavior of the first-run key hint changed from printing an escaped private key to printing only a fingerprint. Add/adjust a test for
_log_key_capture_hint()(patchingsys.stderr) to assert the private key content is not present in the emitted hint and that a fingerprint line is included, so the security regression can’t reappear unnoticed.