feat(trust): implement verification locality (RFC-001 §2.3) by beonde · Pull Request #88 · capiscio/capiscio-core

beonde · 2026-05-27T00:22:34Z

Summary

Implements Phase 0.1-0.4 of Verification Locality per RFC-001 §2.3. This establishes local-first runtime trust verification and mediation boundaries.

Changes

`pkg/trust/` — Trust Material Lifecycle

locality.go: Core types (TrustMaterial, FreshnessPolicy, BootstrapConfig)
bootstrap.go: MaterialManager for trust material lifecycle
jwks_cache.go: Tiered JWKS cache (L1=memory, L2=filesystem)
revocation_cache.go: Local revocation status caching

`pkg/badge/` — Local Verification

local_verifier.go: LocalVerifier for network-independent badge verification

`pkg/mediation/` — Runtime Mediation Boundaries (NEW)

hook.go: Core Hook interface and Result type
context.go: Context with badge claims for mediation decisions
tool.go: ToolHook for MCP tool authorization
filesystem.go: FilesystemHook for file operation boundaries
network.go: NetworkHook for egress control
shell.go: ShellHook for dangerous command detection

Integration

pkg/envelope/verifier.go: TrustMaterial in VerifyOptions
pkg/gateway/middleware.go: LocalVerifier when TrustMaterial bootstrapped

RFC Compliance

Per RFC-001 §2.3:

"Verifiers MUST be able to validate any CapiscIO trust artifact using only locally cached cryptographic material"

This PR ensures:

Verifiers validate trust artifacts using local cached material
No synchronous registry calls in verification critical path
Revocation data distributable as cacheable artifacts

Testing

All tests pass:

go test ./pkg/trust/... ./pkg/badge/... ./pkg/mediation/...
ok  pkg/trust    0.648s
ok  pkg/badge    1.443s
ok  pkg/mediation  0.482s

31 test scenarios across 4 mediation hooks (tool, filesystem, network, shell).

Phase 0.1-0.4 implementation: pkg/trust/: - locality.go: TrustMaterial, FreshnessPolicy, BootstrapConfig types - bootstrap.go: MaterialManager for trust material lifecycle - jwks_cache.go: Tiered JWKS cache (L1=memory, L2=filesystem) - revocation_cache.go: Local revocation status caching pkg/badge/: - local_verifier.go: LocalVerifier for network-independent verification pkg/mediation/: - hook.go: Core Hook interface and mediation context - tool.go: ToolHook for MCP tool authorization - filesystem.go: FilesystemHook for file operation boundaries - network.go: NetworkHook for egress control - shell.go: ShellHook for dangerous command detection pkg/envelope/, pkg/gateway/: - TrustMaterial integration in VerifyOptions and PEPConfig - LocalVerifier creation when TrustMaterial bootstrapped Invariants per RFC-001 §2.3: - Verifiers validate trust artifacts using local cached material - No synchronous registry calls in verification critical path - Revocation data distributable as cacheable artifacts

codecov · 2026-05-27T00:24:48Z

Codecov Report

❌ Patch coverage is 45.72491% with 730 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pkg/trust/jwks_cache.go	27.45%	145 Missing and 3 partials ⚠️
pkg/trust/bootstrap.go	19.87%	122 Missing and 11 partials ⚠️
pkg/trust/revocation_cache.go	40.47%	118 Missing and 7 partials ⚠️
pkg/badge/local_verifier.go	45.25%	55 Missing and 20 partials ⚠️
pkg/trust/locality_test_helpers.go	20.93%	64 Missing and 4 partials ⚠️
pkg/mediation/shell.go	65.09%	29 Missing and 8 partials ⚠️
pkg/mediation/network.go	74.31%	21 Missing and 7 partials ⚠️
pkg/mediation/filesystem.go	71.27%	20 Missing and 7 partials ⚠️
pkg/mediation/tool.go	72.94%	20 Missing and 3 partials ⚠️
pkg/mediation/context.go	52.27%	21 Missing ⚠️
... and 4 more

📢 Thoughts on this report? Let us know!

Copilot

Pull request overview

Implements RFC-001 §2.3 “verification locality” by introducing locally cached trust material (JWKS + revocations), a local/offline badge verification path, and new runtime mediation hooks (tool/filesystem/network/shell). Integrates local-first verification into envelope verification options and gateway PEP middleware when trust material is bootstrapped.

Changes:

Added pkg/trust trust-material lifecycle primitives: JWKS + revocation caches, bootstrap/export/import, and locality test helpers.
Added pkg/badge/LocalVerifier to verify badges using only locally cached trust material.
Introduced pkg/mediation hooks to enforce runtime boundaries and wired local verification into gateway/envelope verification flows.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
pkg/trust/locality.go	Defines trust material types and freshness policy primitives.
pkg/trust/bootstrap.go	Adds `MaterialManager` bootstrap/export/import for local trust material.
pkg/trust/jwks_cache.go	Introduces tiered JWKS cache (memory + filesystem) with TTL semantics.
pkg/trust/revocation_cache.go	Adds revocation cache with staleness policy and async sync hooks.
pkg/trust/locality_test_helpers.go	Adds test helpers intended to detect locality violations.
pkg/trust/locality_test.go	Adds tests around cache locality and freshness evaluation.
pkg/badge/local_verifier.go	Adds offline/local badge verification based on `MaterialManager`.
pkg/badge/local_verifier_test.go	Adds tests for local verifier behavior and locality invariants.
pkg/mediation/doc.go	Documents mediation architecture and locality requirements.
pkg/mediation/hook.go	Defines core Hook/Request interfaces plus logging/emission interfaces.
pkg/mediation/decision.go	Adds mediation decision/result types and helpers.
pkg/mediation/context.go	Adds mediation context carrying verified artifacts and trust material.
pkg/mediation/tool.go	Implements tool invocation mediation.
pkg/mediation/tool_test.go	Adds tests for ToolHook behavior and pattern matching.
pkg/mediation/filesystem.go	Implements filesystem mediation with path canonicalization.
pkg/mediation/filesystem_test.go	Adds tests for filesystem mediation behavior.
pkg/mediation/network.go	Implements network egress mediation with URL parsing and host rules.
pkg/mediation/network_test.go	Adds tests for network mediation behavior.
pkg/mediation/shell.go	Implements shell-command mediation with dangerous-pattern detection.
pkg/mediation/shell_test.go	Adds tests for shell mediation behavior.
pkg/envelope/verifier.go	Adds TrustMaterial option to prefer local badge verification.
pkg/envelope/verifier_test.go	Adds a test intended to cover TrustMaterial option.
pkg/gateway/middleware.go	Uses LocalVerifier for badge verification when TrustMaterial is bootstrapped.
docs/verification-locality-audit.md	Adds an audit document enumerating sync network call sites.

Comments suppressed due to low confidence (1)

pkg/envelope/verifier.go:274

The fallback (registry-based) badge verification path also hard-codes AcceptSelfSigned=true. This weakens default verification semantics compared to badge.Verifier.VerifyWithOptions() which defaults to rejecting self-signed badges unless configured.

	badgeOpts := badge.VerifyOptions{
		TrustedIssuers:       opts.TrustedIssuers,
		AcceptSelfSigned:     true,
		SkipRevocationCheck:  false,
		SkipAgentStatusCheck: false,
	}

- Reduce cyclomatic complexity in mediation hooks (extract helper methods) - Add #nosec G304 for legitimate file operations from configured paths - Fix unnecessary nil check before len() - Add nolint:revive for TrustMaterial name (clearer at call sites)

Fix GO-2026-4945 vulnerability in JWE decryption

Copilot

Pull request overview

Copilot reviewed 26 out of 27 changed files in this pull request and generated 17 comments.

Critical Bug Fixes: - Fix range variable pointer bug in revocation_cache.go (all entries pointed to same address) - Fix nil MaterialManager panic in LocalVerifier.Verify() - Apply DefaultFreshnessPolicy when config.FreshnessPolicy is zero - Fix key lookup to use JWS header kid, not CNF.kid (subject's PoP key) - Add iat validation for future-dated badges - Use badge TrustLevel() not IAL for mediation context - Fix WarnAndAllow returning expired instead of degraded freshness - Respect StalePolicyFailClosed for revocation errors Security Fixes: - Add AcceptSelfSigned option to envelope VerifyOptions (don't force true) - Apply safe defaults (DefaultDeny=true) in mediation hooks when unconfigured - Fix path traversal with ~ prefix in filesystem mediation - SetSyncMetadata now persists both revocations and metadata Code Quality: - Refactor LocalVerifier.Verify to reduce cyclomatic complexity - Remove unused saveMetadataToDisk function - Update test to set VC.CredentialSubject.Level for TrustLevel

…rt, CapabilitySatisfied scoping - Change GetPublicKey return type from any to crypto.PublicKey (type safety) - Improve filenameToIssuer to handle both DID and HTTPS issuer formats - Update CapabilitySatisfied to use envelope.IsWithinScope per RFC-008 §7.2 - Remove invalid '*' wildcard support from capability matching Co-authored-by: GitHub Copilot <copilot@github.com>

Copilot

Pull request overview

Copilot reviewed 26 out of 27 changed files in this pull request and generated 12 comments.

…hange

Copilot AI review requested due to automatic review settings May 27, 2026 00:22

Copilot started reviewing on behalf of beonde May 27, 2026 00:22 View session

Copilot AI reviewed May 27, 2026

View reviewed changes

beonde added 2 commits May 26, 2026 20:35

chore(deps): update go-jose to v4.1.4

d955236

Fix GO-2026-4945 vulnerability in JWE decryption

Copilot AI review requested due to automatic review settings May 27, 2026 00:38

Copilot started reviewing on behalf of beonde May 27, 2026 00:38 View session

Copilot AI reviewed May 27, 2026

View reviewed changes

beonde and others added 2 commits May 26, 2026 21:55

Copilot AI review requested due to automatic review settings May 27, 2026 01:58

Copilot started reviewing on behalf of beonde May 27, 2026 01:59 View session

Copilot AI reviewed May 27, 2026

View reviewed changes

fix: remove redundant type assertion after GetPublicKey return type c…

5e57ff2

…hange

beonde merged commit 0f5bb39 into main May 27, 2026
5 checks passed

beonde deleted the feat/verification-locality branch May 27, 2026 15:11

This was referenced May 27, 2026

feat(mediation): implement RFC-011 runtime events #89

Merged

feat(gateway): wire RFC-011 AsyncEmitter into PEP middleware #90

Merged

Conversation

beonde commented May 27, 2026

Summary

Changes

pkg/trust/ — Trust Material Lifecycle

pkg/badge/ — Local Verification

pkg/mediation/ — Runtime Mediation Boundaries (NEW)

Integration

RFC Compliance

Testing

Related

Uh oh!

codecov Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`pkg/trust/` — Trust Material Lifecycle

`pkg/badge/` — Local Verification

`pkg/mediation/` — Runtime Mediation Boundaries (NEW)

codecov Bot commented May 27, 2026 •

edited

Loading