Use workflows from https://github.com/cap-java/.github/#844
Merged
Conversation
Contributor
There was a problem hiding this comment.
The PR centralises CI/CD logic by delegating to shared reusable workflows and actions in cap-java/.github, which is a clean maintainability improvement. However, three issues were flagged: the permissions: {} guard was dropped from stale.yml (least-privilege regression), the sonar-project-key input value should be verified against what the central action actually expects, and the CF service bindings performed before the SonarQube step may be lost if the central action performs an internal checkout.
PR Bot Information
Version: 1.21.0
- Event Trigger:
pull_request.opened - LLM:
anthropic--claude-4.6-sonnet - Correlation ID:
f0972ec1-2545-4237-a725-09c1f8aeddf0 - Agent Instructions:
- File Content Strategy: Full file content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate CI/CD Workflows to Shared
cap-java/.githubActionsChore
♻️ Refactor: Replaced locally-defined GitHub Actions and workflow steps with reusable shared workflows and actions from the central
cap-java/.githubrepository, reducing duplication and centralizing CI/CD maintenance.Changes
.github/actions/build/action.yml: Removed — now delegated tocap-java/.github/actions/build@main..github/actions/deploy-release/action.yml: Removed — now delegated tocap-java/.github/actions/deploy-release@main..github/actions/scan-with-blackduck/action.yml: Removed — now delegated tocap-java/.github/actions/scan-with-blackduck@main..github/actions/scan-with-codeql/action.yml: Removed — now delegated tocap-java/.github/actions/scan-with-codeql@main..github/actions/scan-with-sonar/action.yml: Removed — now delegated tocap-java/.github/actions/scan-with-sonar@main..github/workflows/issue.yml: Replaced inline issue labeling and comment logic with a call to the sharedcap-java/.github/.github/workflows/issue.yml@mainworkflow..github/workflows/prevent-issue-labeling.yml: Replaced inline label-removal logic with a call tocap-java/.github/.github/workflows/prevent-issue-labeling.yml@main..github/workflows/stale.yml: Removed inline stale issue handling steps; now delegates tocap-java/.github/.github/workflows/stale.yml@main. Also removed explicitpermissions: {}block..github/workflows/main.yml: Updated BlackDuck scan action reference from local to shared; added explicitproject-nameandincluded-modulesinputs..github/workflows/pr.yml: Updated BlackDuck scan action reference from local to shared; addedproject-nameandincluded-modulesinputs..github/workflows/pipeline.yml: Updated SonarQube and CodeQL action references from local to shared; addedsonar-project-key,coverage-report-path,build-script, andcoverage-exclusionsinputs to the SonarQube step..github/workflows/release.yml: Updated BlackDuck, build, and deploy action references from local to shared; addedproject-nameandincluded-modulesinputs to the BlackDuck step.PR Bot Information
Version:
1.21.0pull_request.openedanthropic--claude-4.6-sonnetf0972ec1-2545-4237-a725-09c1f8aeddf0