Skip to content

Don't type cast non-sensible values #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
voxpelli wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't type cast non-sensible values #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions lib/fields.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ var validators = require('./validators');
var coerceArray = function (arr) {
return is.array(arr) && arr.length > 0 ? arr : [];
};
var isSingleFieldData = function (raw_data) {
return is.string(raw_data) || is.number(raw_data);
};
var nameSeparatorRegExp = /[_-]/g;

exports.string = function (options) {
Expand All @@ -21,10 +24,7 @@ exports.string = function (options) {
f.widget = f.widget || forms.widgets.text(opt.attrs || {});

f.parse = function (raw_data) {
if (typeof raw_data !== 'undefined' && raw_data !== null) {
return String(raw_data);
}
return '';
return isSingleFieldData(raw_data) ? String(raw_data) : '';
};
f.bind = function (raw_data) {
var b = assign({}, f); // clone field object:
Expand Down Expand Up @@ -112,10 +112,10 @@ exports.number = function (opt) {
var f = exports.string(opts);

f.parse = function (raw_data) {
if (raw_data === null || raw_data === '') {
if (raw_data === '') {
return NaN;
}
return Number(raw_data);
return isSingleFieldData(raw_data) ? Number(raw_data) : NaN;
};
return f;
};
Expand All @@ -126,7 +126,10 @@ exports['boolean'] = function (opt) {

f.widget = opts.widget || forms.widgets.checkbox(opts.attrs || {});
f.parse = function (raw_data) {
return !!raw_data;
if (is.bool(raw_data)) {
return raw_data;
}
return !!(raw_data && isSingleFieldData(raw_data));
};
return f;
};
Expand Down