Add plugins support in auto update #292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rem1niscence
requested changes
Jan 28, 2026
Collaborator
rem1niscence
left a comment
rem1niscence
left a comment
There was a problem hiding this comment.
A refactor of the autoupdater code is required in order for this to be scalable and merged for production usage, in the comments I left multiple suggestions on how to do it but basically it resumes into
- not creating specialized structs
PluginReleasebut augment the ones that already existsRelease - Do not create special logic for plugin lifetime on the coordinator but reuse the
Supervisorto manage the plugins through it, and the coordinator will simply need to loop through them and update as needed - This is not on the comments but also required: Right now the plugin update and canopy release update are done together, that is dangerous and could leave the system on a broken state if any of the plugin fails for whatever reasone, the canopy binary must always run so the plugin lifetime/update must be done separate from the canopy binary
pablocampogo
force-pushed
the
plugins-fresh
branch
from
cea6e1e to
f6c835f
Compare
Collaborator
rem1niscence
left a comment
rem1niscence
left a comment
There was a problem hiding this comment.
The main takeaway from this review is to not have any hardcoded values in both coordinator.go and updater.go. Add those values to the main.go and pass them as configs
…coded in the same place
pablocampogo
force-pushed
the
plugins-fresh
branch
from
b75f4dd to
3a87c6a
Compare
pablocampogo
force-pushed
the
plugins-fresh
branch
from
513aea3 to
47d4b46
Compare
pablocampogo
force-pushed
the
plugins-fresh
branch
from
47d4b46 to
f871cc1
Compare
rem1niscence
requested changes
Feb 2, 2026
Collaborator
rem1niscence
left a comment
rem1niscence
left a comment
There was a problem hiding this comment.
code is getting better, keep up the good work
pablocampogo
changed the title
rem1niscence
requested changes
Feb 3, 2026
rem1niscence
approved these changes
Feb 3, 2026
Collaborator
|
Do not merge yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add plugins support in auto update