efi/preinstall: relax checkSecureBootPolicyForDegradedFirmwareSettings#526
Merged
chrisccoulson merged 1 commit intocanonical:masterfrom Mar 10, 2026
Merged
Conversation
This function shouldn't fail on unexpected event types. Instead, the unexpected event types should trigger errors later on, resulting in more appropriate error messages. Fixes: FR-12830 Fixes: canonical#514
pedronis
reviewed
Mar 10, 2026
| c.Check(err, ErrorMatches, `unexpected EV_EFI_ACTION event data in PCR7 event: \"Calling EFI Application from Boot Option\"`) | ||
| } | ||
|
|
||
| func (s *hostSecuritySuite) TestCheckSecureBootPolicyPCRForDegradedSettingsErrUnexpectedType(c *C) { |
Collaborator
There was a problem hiding this comment.
do we have an equivalent test for the higher level?
Collaborator
Author
There was a problem hiding this comment.
Yes, there are tests in check_pcr7_test.go that check unexpected event types are caught.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function shouldn't fail on unexpected event types. Instead, the
unexpected event types should trigger errors later on, resulting in more
appropriate error messages.
Fixes: FR-12830
Fixes: #514