Preinstall improve csme manufacturing mode check#525
Merged
chrisccoulson merged 1 commit intocanonical:masterfrom Mar 10, 2026
Merged
Conversation
This refines the checks that run on Intel systems so that appropriate error messages are returned if the system is in manufacturing mode. The changes are based on checks in the coreboot repository, specifically https://github.com/coreboot/coreboot/blob/eb5bdf06b92534b6f66f612297a4ccb69008b4ac/src/soc/intel/common/block/cse/cse_spec.c#L15 Fixes: FR-12761 Fixes: canonical#515
chrisccoulson
force-pushed
the
preinstall-improve-csme-manufacturing-mode-check
branch
from
9998096 to
fc91a56
Compare
pedronis
reviewed
Mar 10, 2026
Collaborator
pedronis
left a comment
pedronis
left a comment
There was a problem hiding this comment.
double checking question
| } | ||
|
|
||
| const ( | ||
| hfsts1Csme18SPIProtectionMode hfsts1Csme18 = 1 << 4 |
Collaborator
There was a problem hiding this comment.
double checking, this is the same bit as in 11 but different naming?
Collaborator
Author
There was a problem hiding this comment.
It is. There's some confusion about the naming - fwupd has it as "manufacturing mode" for CSME11 and "SPI protection mode" for CSME18, coreboot calls it "manufacturing mode" everywhere and slimbootloader calls it "SPI protection mode" almost everywhere with the exception of 1 CPU family. I think the bit means the same thing in both cases though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refines the checks that run on Intel systems so that appropriate
error messages are returned if the system is in manufacturing mode. The
changes are based on checks in the coreboot repository, specifically
https://github.com/coreboot/coreboot/blob/eb5bdf06b92534b6f66f612297a4ccb69008b4ac/src/soc/intel/common/block/cse/cse_spec.c#L15
Fixes: FR-12761
Fixes: #515