efi/preinstall: Don't require Platform Secure Boot on AMD#524
Merged
chrisccoulson merged 3 commits intocanonical:masterfrom Mar 10, 2026
Merged
Conversation
chrisccoulson
force-pushed
the
preinstall-relax-amd-checks
branch
from
9fad968 to
0d943e0
Compare
pedronis
reviewed
Mar 9, 2026
|
|
||
| func (s *hostSecurityIntelSuite) TestCheckHostSecurityIntelCPUDebuggingLockedDisabledCPUID(c *C) { | ||
| env := efitest.NewMockHostEnvironmentWithOpts(efitest.WithAMD64Environment("GenuineIntel", nil, 1, map[uint32]uint64{0xc80: 0})) | ||
| env := efitest.NewMockHostEnvironmentWithOpts(efitest.WithAMD64Environment("GenuineIntel", 0x12, nil, 1, map[uint32]uint64{0xc80: 0})) |
Collaborator
There was a problem hiding this comment.
is 0x12 meant to be a realistic value here? same for other usages of it in the tests
Collaborator
Author
There was a problem hiding this comment.
It is, although I've updated it to be a more likely value now - not that it matters too much as it's only used for the AMD checks.
Based on the understanding that the ASP still acts as the root-of-trust for measurement when PSB is disabled, permit platforms with an AMD CPU when PSB is disabled. In this case, as firmware integrity is provided by measured boot, we require profiles to be locked to PCR0 which is not necessary when PSB is enabled.
chrisccoulson
force-pushed
the
preinstall-relax-amd-checks
branch
from
0d943e0 to
e55d961
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the understanding that the ASP still acts as the root-of-trust
for measurement when PSB is disabled, permit platforms with an AMD CPU
when PSB is disabled. In this case, as firmware integrity is provided by
measured boot, we require profiles to be locked to PCR0 which is not
necessary when PSB is enabled.