[DPE-3310] New DataPeer(Unit) objects handling Peer Relation Data (so far secrets only) #332
Closed
juditnovak wants to merge 4 commits into6/edgefrom
Closed
[DPE-3310] New DataPeer(Unit) objects handling Peer Relation Data (so far secrets only) #332juditnovak wants to merge 4 commits into6/edgefrom
juditnovak wants to merge 4 commits into6/edgefrom
Conversation
github-actions
Bot
added
the
Libraries: OK
juditnovak
force-pushed
the
DPE-3310_data_platform_libs_peer_data
branch
from
7139e68 to
dcad8af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of implementing Peer Data interactions locally, we've introduced the same abstraction layer for Peer Relation Data as it was implemented for Cross-charm Relation data.
This can be used via the same interfaces as Cross-charm Relations Data interfaces (on the latter see https://discourse.canonical.com/t/data-platform-relation-interfaces-using-juju-secrets/2808).
So far we only benefitted of the new abstraction layer to access secret fields -- however ideally it could (should?) replace databag access equally, allowing for abstract Peer Relation Data access (as mandatory for Cross-charm).
NOTE: This solution is Juju 3.1.7 compatible (also with backwards compatibilty)
See the same code over Juju 3.1.7: #333