Send raw surface application_id in foreign toplevel app_id events#4955
Draft
Copilot wants to merge 2 commits into
Draft
Send raw surface application_id in foreign toplevel app_id events#4955Copilot wants to merge 2 commits into
application_id in foreign toplevel app_id events#4955Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/canonical/mir/sessions/bc00ca1f-9f3a-45ac-b37a-3d2b58fbe5eb Co-authored-by: AlanGriffiths <9048879+AlanGriffiths@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix handling of application_id for consistency
Send raw surface May 21, 2026
application_id in foreign toplevel app_id events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #4946
What's new?
application_idhandling was inconsistent: we stored the raw value but repeatedly resolved it to desktop-file-derived IDs at emission points. This change keepsapp_idprotocol output aligned with the surface’s actualapplication_idand stops overloading that field with desktop-file resolution.Foreign toplevel app_id semantics
wlr-foreign-toplevel-managementandext-foreign-toplevel-listnow emit rawsurface->application_id()(and the observer callback’sapplication_id) directly.DesktopFileManager::resolve_app_id(...)in:src/server/frontend_wayland/foreign_toplevel_manager_v1.cppsrc/server/frontend_wayland/foreign_toplevel_list_v1.cppScope intentionally limited
DesktopFileManagerresolution logic remains available for contexts that explicitly need desktop-file lookup.How to test
app_idnow matches the surface-setapplication_idexactly, including cases that previously mapped to desktop file IDs (e.g.gnome-terminal-server).set_app_idpropagate the exact value provided by the client.Checklist
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either: