Skip to content

fix(openstack): correct bond parameter translation for sysconfig #6576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ftarasenko wants to merge 1 commit into from
Closed

fix(openstack): correct bond parameter translation for sysconfig #6576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloudinit/sources/helpers/openstack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,7 @@ def convert_net_json(network_json=None, known_macs=None):
# cloudinit schema but 'bond_' in OpenStack
# network_data.json schema. Translate them to what
# is expected by cloudinit.
translated_key = "bond-{}".format(k.split("bond_", 1)[-1])
translated_key = k.replace("_", "-")
params.update({translated_key: v})

# openstack does not provide a name for the bond.
Expand Down
4 changes: 2 additions & 2 deletions tests/unittests/sources/helpers/test_openstack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def test_bond_mac(self):
"params": {
"bond-miimon": 100,
"bond-mode": "802.3ad",
"bond-xmit_hash_policy": "layer3+4",
"bond-xmit-hash-policy": "layer3+4",
},
"subnets": [],
"type": "bond",
Expand Down Expand Up @@ -321,7 +321,7 @@ def test_dns_servers(self):
"mac_address": "xx:xx:xx:xx:xx:00",
"params": {
"bond-mode": "802.3ad",
"bond-xmit_hash_policy": "layer3+4",
"bond-xmit-hash-policy": "layer3+4",
"bond-miimon": 100,
},
"bond_interfaces": ["ens1f0np0", "ens1f1np1"],
Expand Down
Loading