Add NPU tests (New)#2198
Conversation
40b763c to
3c0ef4f
Compare
|
@fernando79513 and @tomli380576, can you please review this PR? |
pseudocc
left a comment
There was a problem hiding this comment.
Just a passersby reviewer, see inline comments.
There was a problem hiding this comment.
Test scripts lgtm! Could you provide a bit of documentation on what the expectations are for NPU_UMD_TEST_CONFIG like where it's supposed to be placed at, permissions, what exactly are the expected contents (for example the tree output of a correct setup), etc.
One small question: is the driver snap expected to come preinstalled? If not, I think we should print an error somewhere or mention it in the manifest.
The snap is not pre-installed but ideally the devices that do have the has_npu manifest entry should install the snap before running checkbox... Is there any way in checkbox to define this dependency and maybe even have the snap auto-installed by checkbox? |
pseudocc
left a comment
There was a problem hiding this comment.
Looks good to me now, thanks!
|
To make this case depend on whether the driver snap exists, add |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2198 +/- ##
==========================================
+ Coverage 55.56% 56.21% +0.64%
==========================================
Files 413 425 +12
Lines 44692 45873 +1181
Branches 8235 8335 +100
==========================================
+ Hits 24834 25786 +952
- Misses 19003 19308 +305
+ Partials 855 779 -76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I see, I have actually avoided using the dependency exactly so that it would be an explicit failure if the snap is not present but As a side note, I think it would be useful to have something like Ansible's |
fernando79513
left a comment
There was a problem hiding this comment.
I left a few more comments on the PR.
My main concern is with the "non-blocker" jobs. I am not sure under which conditions you expect them to fail, but we should not add them to the test plan if they are not expected to pass.
Apart from that, could you add some submissions of devices in the lab running the NPU tests with the new provider?
|
Also, I have a couple of questions.
|
@fernando79513 Thank you for your review! The
Sure, I'll upload those. |
@vandah I think that's an ongoing question and I am not sure I can answer it right now, but if you can attend the office hours this week, it would be a good place to discuss about it |
Ok, I'll be there! |
fernando79513
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution and your patience during the review process.
I think we are good to go now with this PR.
LGTM +1!
Description
This PR adds tests for testing devices with an NPU.
They are currently focused on Intel NPUs which use the accel kernel interface.
The driver for these NPUs is distributed through the
intel-npu-driversnap which also includes a gtest-based testing utilitynpu-umd-test. The tests check the appropriate firmware version is loaded, the user has the appropriate permissions and the rest runs individual tests from thenpu-umd-testutility.The latest version of the
intel-npu-driversnap now includes also the configuration file and model files necessary for running thenpu-umd-testas well as aknown-failurescommand which I've used to simplify the test filtering. The configuration file and list of known failures will be maintained as part of theintel-npu-driversnap as they can change from one version to another.Known issues
Some of the test names coming from the
npu-umd-testtest suite are longer than 80 characters which triggers a warning in checkbox.Tests
Tests have been run on Meteor Lake and Arrow Lake devices.
Meteor Lake run - submission_2026-02-20T00.04.24.655939.zip