Add Safe instance manual signing helpers#190
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds instance methods to SafeAccount and SafeMultiChainSigAccountV1 for building EIP-712 typed data, computing its hash, and formatting UserOperation signatures; refactors single-op multichain signature formatting, wires multichain gas estimation, updates README, and adds tests. ChangesInstance helpers for manual EIP-712 UserOperation signing
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
|
Actionable comments posted: 0 |
d68cadb to
8cc4dc2
Compare
|
Actionable comments posted: 0 |
8cc4dc2 to
9be7fff
Compare
|
Actionable comments posted: 0 |
Summary
Tests
Summary by CodeRabbit
New Features
Documentation
Tests