Feature/cli migrate with testing#125
Draft
arekouzounian wants to merge 3 commits intocamerondurham:mainfrom
Draft
Feature/cli migrate with testing#125arekouzounian wants to merge 3 commits intocamerondurham:mainfrom
arekouzounian wants to merge 3 commits intocamerondurham:mainfrom
Conversation
added 3 commits
May 15, 2025 11:17
- testing suites for langs - client mocks using the new Requester interface - HTTP mocks using the `httptest` package
Collaborator
Author
|
Going to flag this as a draft right now; this is my first attempt at using Gomock so I'm open to any feedback on how I can improve the tests and/or make them more idiomatic. I could also implement some more blackbox tests that run against the actual deployment to check for expected behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
langsandruncommands to use the updated APItimeoutoption to the root command for adjusting client timeoutsClientobject to take in a Requester, for use in mocks