test: add NIP-17 gift wrap integration tests#529
Merged
cameri merged 3 commits intocameri:mainfrom Apr 19, 2026
Merged
Conversation
Collaborator
Collaborator
Author
|
Hi @cameri , I used "Anshuman" as the actor name instead of "Alice" in the new NIP-17 integration scenarios. I noticed most existing integration tests use Alice/Bob naming, so I'm happy to switch back to "Alice" for consistency if you'd prefer :) |
Owner
|
@Anshumancanrock let's please stick to generic names please (Alice, Bob, Charlie) |
Collaborator
Author
@cameri Done ! |
cameri
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds end-to-end integration coverage for NIP-17 gift wrap validation. It covers one accepted path and the requested rejection/query cases: missing p tag, multiple p tags, malformed NIP-44 payload, and recipient lookup via #p filter.
Related Issue
Closes #504
Motivation and Context
Gift wrap validation rules existed in strategy code but were not covered by integration tests. This adds regression coverage for expected behavior and error messages.
How Has This Been Tested?
Screenshots (if appropriate):
N/A
Types of changes
Checklist: