Skip to content

test: set minimum unit test coverage thresholds #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cameri merged 2 commits into from
Apr 18, 2026
Merged

test: set minimum unit test coverage thresholds #486

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b116a25
test: set minimum coverage thresholds to current levels
Apr 18, 2026
624808a
Merge branch 'main' into feat/minimum-coverage-threshold
cameri Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .nycrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
{
"all": true,
"cache": true,
"branches": 80,
"lines": 80,
"functions": 80,
"statements": 80,
"branches": 47,
"lines": 54,
"functions": 48,
"statements": 55,
Comment on lines +4 to +7
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The numeric thresholds (branches/lines/functions/statements) are only enforced by nyc when coverage checking is enabled (e.g., via --check-coverage or "check-coverage": true). As written, CI runs nyc ... npm run test:unit without --check-coverage, so these values may not actually prevent coverage regressions despite the PR description. Consider enabling check-coverage in this config or adding --check-coverage to the cover:* scripts.

Copilot uses AI. Check for mistakes.
Comment on lines +4 to +7
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This .nycrc.json is used by both cover:unit and cover:integration (the integration docker compose mounts it into the container). Lowering thresholds/watermarks here will apply to integration coverage too, even though the PR title/description frames this as “unit test” thresholds. If the intent is unit-only gating, consider splitting configs (e.g., .nycrc.unit.json / .nycrc.integration.json) and pointing each script to the appropriate file.

Copilot uses AI. Check for mistakes.
"watermarks": {
"lines": [
80,
95
54,
80
],
"functions": [
80,
95
48,
80
],
"branches": [
80,
95
47,
80
],
"statements": [
80,
95
55,
80
]
},
"extension": [
Expand Down
Loading