UX: XHR to prevent page from flickering while polling for results#85
Open
ForestJohnson wants to merge 2 commits intocamelot-dev:masterfrom
Open
UX: XHR to prevent page from flickering while polling for results#85ForestJohnson wants to merge 2 commits intocamelot-dev:masterfrom
ForestJohnson wants to merge 2 commits intocamelot-dev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I first wrote this code before I realized someone else had alreadu solved it with a meta tag. (the most recent release still has the "you must refresh the page yourself" text)
The meta tag probably works so its probably fine how it is...
I guess if you wanted to have an animated progress bar with css transitions or something, you would have to do an XHR but I don't think its really necessary so feel free to close this if you want