Open
Conversation
Intended to resolve camelot-dev#643
This having no upper bound seems crazy risky to me, but none of the dependencies in this project do, so changing that across the board is probably out of scope for this branch.
Author
|
I've not bumped the version number yet because I'm not sure what the protocol is there. I see at least one other PR is proposing a release candidate for v1.0.10, but I also see that it's failing some checks. I would ideally like to also see at least #650 and #643 merged as well, if possible, along with anything else that seems like a clear benefit. @vinayak-mehta Tagging you might be bad form, so I'm sincerely sorry if it is, but I'm not sure how else to check in. Hope you're OK! Please see linked issue re. CVE that prompted this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to resolve #643. My preliminary testing indicates that it does.
Since #610 isn't merged (I'm not sure why), I'm dropping Python 3.8 here as well, because pypdf v6 requires Python >= 3.9.