[MRG] Add a test for when the cli version is not found#653
Open
DoomedJupiter wants to merge 5 commits intocamelot-dev:masterfrom
Open
[MRG] Add a test for when the cli version is not found#653DoomedJupiter wants to merge 5 commits intocamelot-dev:masterfrom
DoomedJupiter wants to merge 5 commits intocamelot-dev:masterfrom
Conversation
added a test for when the version is not found
minor formatting change to pass pre-commit CI tests
added new line at end of file, to pass pre-commit CI tests
added a comma, to pass pre-commit CI tests, ...hopefully
removed a space, to pass pre-commit CI tests, definitely this time
Collaborator
Author
|
Learned how to run pre-commit checks offline, so I don't do this again. The failed 3.8/ubuntu-latest test should be rectified in PR #650 and does not affect this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
get_version()function incli.pywas added a few months back. It looks like this was not covered by a test and appears to cause codecov/project failures on recent PRs. This test should correct that.