fix: add explicit type: object to DeviceResponseBody (S-016)#154
Open
hdamker wants to merge 1 commit intocamaraproject:mainfrom
Open
fix: add explicit type: object to DeviceResponseBody (S-016)#154hdamker wants to merge 1 commit intocamaraproject:mainfrom
hdamker wants to merge 1 commit intocamaraproject:mainfrom
Conversation
Contributor
Author
|
@Kevsy raised by validation with r4.x as error, the same rule is not in r3.4 ruleset, so not strictly needed for the maintenance release r2.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds the missing
type: objectto theDeviceResponseBodyschema insimple-edge-discovery.yaml. Surfaced by CAMARA validation rule S-016(
camara-schema-must-have-type) while preparing the r2.3 maintenancerelease.
The schema declares
propertiesbut no explicit type; this is aCommonalities requirement — every schema should declare its type.
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Will be required by 4.x validation, not strictly needed for r2.3
Changelog input
Additional documentation