Add new changes for Sync26 (geohashlist)#123
Open
albertoramosmonagas wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This PR extends the Population Density Data API with support for a new optional area type:
GEOHASHLIST.POLYGONremains the mandatory area type for all MNO implementations, whileGEOHASHLISTis introduced as an optional area representation for providers that can support geohash-based requests. Changes included:GEOHASHLISTvalue toareaType.GeohashListandGeohashschemas.^[0-9bcdefghjkmnpqrstuvwxyz]{1,12}$precisionfield toPOLYGONrequests only. Ifprecisionis provided together withGEOHASHLIST, the API returns400 INVALID_ARGUMENT.422error:POPULATION_DENSITY_DATA.UNSUPPORTED_AREA_TYPEto indicate that the requestedareaTypeis valid in the API specification but not supported by the MNO.CellPopulationDensityData.geohashto reference the commonGeohashschema, ensuring the same geohash definition is reused in both request and response models.GEOHASHLISTbehaviour:NO_DATA;AREA_NOT_SUPPORTED.This PR also clarifies the behaviour for unsupported precision values:
1–12, the request is rejected with400 INVALID_ARGUMENT.422 POPULATION_DENSITY_DATA.UNSUPPORTED_PRECISIONThis applies both to the
precisionfield forPOLYGONrequests and to the length of each geohash inGEOHASHLISTrequests.Which issue(s) this PR fixes:
Fixes #110, #109, #105
Special notes for reviewers:
This PR is based on conversations that can be followed at #110.
Changelog input
Additional documentation
This section can be blank.