docs: add prioritized PR review issues analysis#185
Conversation
|
Co-authored-by: MihalyToth20 <34799518+MihalyToth20@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds a new planning document that consolidates and prioritizes previously identified review issues for the “registry refactor” work, intended to guide remediation order before/after merge.
Changes:
- Add
/plans/pr-review-issues-prioritized.mdwith 13 issues grouped into Critical/High/Medium/Low tiers. - Include per-issue impact statements, file references, and recommended remediation steps.
- Provide a recommended fix order and merge-blocker callouts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ### 2. TypeScript Compilation Failure - Missing BranchConfig Import | ||
|
|
||
| **File**: `packages/core/src/index.ts:544-548` | ||
|
|
||
| **Issue**: `BranchConfig` is referenced in the `installRegistryItemToXano` signature but is not imported in this file. | ||
|
|
||
| **Impact**: TypeScript compilation will fail, blocking builds | ||
|
|
||
| **Action Required**: Import `BranchConfig` alongside `InstanceConfig`/`WorkspaceConfig` from `@repo/types` | ||
|
|
||
| **Priority Justification**: Compilation errors block all development and deployment. |
There was a problem hiding this comment.
Section #2 appears to be outdated/incorrect: packages/core/src/index.ts already imports BranchConfig from @repo/types, so this is not currently a TypeScript compilation failure. Please either remove this issue from the prioritized list or update it to reflect the actual remaining compilation blocker (and correct file/line references).
Created a comprehensive analysis of all 13 issues identified in the PR code review, ranked by severity and impact.
Changes
/plans/pr-review-issues-prioritized.mdIssue Breakdown
Critical (must fix before merge):
BranchConfigimport causing TypeScript compilation failureInstallParams.instanceConfigHigh (should fix before merge):
results.skippednever populated (UX regression)readdir()double-slash andreadFile()binary handling bugsMedium/Low:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.