Open
Conversation
… choose IC for BP
neelayjunnarkar
requested changes
Nov 25, 2018
Member
There was a problem hiding this comment.
- All hardware should be in a
hardwarefolder (and firmware should go in afirmwarefolder). - All components in the schematic should have value displayed (select all and have Marking 2 be Value)
- It seems mainly the components in voltage regulator block are missing this
- There is a V in the voltage regulator input that faces sideways instead of up
- Make text not overlap (looking at the RS422 blocks and the Programmer block at the very least)
- The RstEn square pin should be ground
- The silkscreen on the Engine molex micro-lock-plus (tm) connector should face out of the board rather than into it
10/10 Net class 'Thiccc'
Member
Author
|
RstEn on what?, also, does "facing out" mean flip text upside-down? |
Member
|
L2 and L3 in the schematic still need to have their values show, and the folder should be firmware (not software) but the other issues have been addressed. |
…ALLY), blackbox testing easier
…ngine controller on layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.